Skip to content

Conversation

@crisbeto
Copy link
Member

Fixes a linter error that is currently breaking the CI.

Fixes a linter error that is currently breaking the CI.
@crisbeto crisbeto requested a review from kara February 10, 2017 05:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 10, 2017
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wondering why Travis was green on the PR (rebased)

@crisbeto
Copy link
Member Author

FWIW, I had to update tslint to get it to show up.

@devversion
Copy link
Member

Ah yeah seems to be because of 902edd0

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 10, 2017
@tinayuangao tinayuangao merged commit 1ab1af1 into angular:master Feb 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants